Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes that are only in 1.14 branch #3704

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jhendersonHDF
Copy link
Collaborator

No description provided.

@jhendersonHDF jhendersonHDF added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C Library Core C library issues (usually in the src directory) Type - Task Actions that don't fit into any other type category labels Oct 18, 2023
@@ -4680,7 +4680,7 @@ SUBROUTINE h5pget_fill_value_ptr(prp_id, type_id, fillvalue, hdferr)
IMPLICIT NONE
INTEGER(HID_T), INTENT(IN) :: prp_id
INTEGER(HID_T), INTENT(IN) :: type_id
TYPE(C_PTR) :: fillvalue
TYPE(C_PTR) , INTENT(IN) :: fillvalue
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brtnfld Is this the correct way to go with this? In develop there is no marked intent; only in the 1.14 branch, which appears to have happened during a previous merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have no intent parameter

@derobins derobins merged commit 9557256 into HDFGroup:develop Oct 18, 2023
40 checks passed
@jhendersonHDF jhendersonHDF deleted the minor_fix branch October 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - C Library Core C library issues (usually in the src directory) Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Task Actions that don't fit into any other type category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants